[
https://issues.apache.org/jira/browse/FLINK-25421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600295#comment-17600295
]
João Boto edited comment on FLINK-25421 at 9/5/22 9:34 AM:
-----------------------------------------------------------
[~martijnvisser] I have some doubts for the {{TwoPhaseCommittingSink}} as this
works great with XA connections, but could be difficult with non-XA connections
(the default)
In current implementation we have JdbcSink (for non-XA) and JdbcXaSink (for XA)
and could be better to maintain the 2 sinks separated.
We could implement the basic sink extending AsyncSink ({{{}StatefulSink{}}})
and then discuss how to implement the {{TwoPhaseCommittingSink.}}
What do you think?
was (Author: eskabetxe):
[~martijnvisser] I have some doubts for the {{TwoPhaseCommittingSink}} as this
works great with XA connections, but could be difficult with non-XA connections
(the default)
In current implementation we have JdbcSink (for non-XA) and JdbcXaSink (for XA)
and could be better to maintain the 2 sinks separated.
We could implement the basic sink extending AsyncSink ({{{}StatefulSink{}}})
and then discuss how to implement the {{TwoPhaseCommittingSink.}}
What do you think?{{{}{}}}
> Port JDBC Sink to new Unified Sink API (FLIP-143)
> -------------------------------------------------
>
> Key: FLINK-25421
> URL: https://issues.apache.org/jira/browse/FLINK-25421
> Project: Flink
> Issue Type: Improvement
> Reporter: Martijn Visser
> Priority: Major
>
> The current JDBC connector is using the old SinkFunction interface, which is
> going to be deprecated. We should port/refactor the JDBC Sink to use the new
> Unified Sink API, based on FLIP-143
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-143%3A+Unified+Sink+API
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
