ASF GitHub Bot commented on FLINK-4564:

Github user zentol commented on the issue:

    Currently, when a metric is registered the reporter also receives the group 
it was registered on as an argument. Since this group is shared by all 
reporters we can't do any tricks in them to be reporter specific.
    Instead, we could create a single reporter specific AbstractMetricGroup 
that is aware of the reporter index, which contains a AbstractMetricGroup 
reference. All calls to methods are forwarded to the reference, with the index 
being supplied when necessary. This reference is set when a metric is 
registered. Does that make sense?

> [metrics] Delimiter should be configured per reporter
> -----------------------------------------------------
>                 Key: FLINK-4564
>                 URL: https://issues.apache.org/jira/browse/FLINK-4564
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>    Affects Versions: 1.1.0
>            Reporter: Chesnay Schepler
> Currently, the delimiter used or the scope string is based on a configuration 
> setting shared by all reporters. However, different reporters may have 
> different requirements in regards to the delimiter, as such we should allow 
> reporters to use a different delimiter.
> We can keep the current setting as a global setting that is used if no 
> specific setting was set.

This message was sent by Atlassian JIRA

Reply via email to