gaoyunhaii commented on code in PR #20733:
URL: https://github.com/apache/flink/pull/20733#discussion_r963387745
##########
flink-runtime/src/main/java/org/apache/flink/runtime/messages/webmonitor/JobDetails.java:
##########
@@ -411,7 +382,26 @@ public JobDetails deserialize(
lastUpdateTime,
numVerticesPerExecutionState,
numTasks,
- attempts);
+ new HashMap<>());
+ }
+ }
+
+ public static final class CurrentAttempts implements Serializable {
Review Comment:
Might need comments to pass checkstyle?
##########
flink-runtime/src/main/java/org/apache/flink/runtime/messages/webmonitor/JobDetails.java:
##########
@@ -411,7 +382,26 @@ public JobDetails deserialize(
lastUpdateTime,
numVerticesPerExecutionState,
numTasks,
- attempts);
+ new HashMap<>());
+ }
+ }
+
+ public static final class CurrentAttempts implements Serializable {
+ private final int representativeAttempt;
+
+ private final List<Integer> currentAttempts;
Review Comment:
Sorry for not think about it initially, but we might change the data
structure to Set<Integer> since the only usage of this field is to query
existence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
