morhidi commented on code in PR #363:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/363#discussion_r963621189


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/StatusRecorder.java:
##########
@@ -196,6 +197,7 @@ public Instant getTimestamp() {
                                     listener.onSessionJobStatusUpdate(ctx);
                                 }
                             });
+                    ListenerUtils.logContext(ctx);

Review Comment:
   With this approach we have a nice and aligned table on these logs, when I 
grep it is easier to grep on ListenerUtils.
   ```
   2022-09-06 13:19:47,920 o.a.f.k.o.l.ListenerUtils      [INFO ] 
[default.basic-example] >>> Status | Info    | UPGRADING       | The resource 
is being upgraded 
   2022-09-06 13:19:48,030 o.a.f.k.o.l.ListenerUtils      [INFO ] 
[default.basic-example] >>> Event  | Info    | Submit          | Starting 
deployment
   2022-09-06 13:19:48,672 o.a.f.k.o.l.ListenerUtils      [INFO ] 
[default.basic-example] >>> Status | Info    | DEPLOYED        | The resource 
is deployed/submitted to Kubernetes, but it’s not yet considered to be stable 
and might be rolled back in the future 
   2022-09-06 13:19:52,700 o.a.f.k.o.l.ListenerUtils      [INFO ] 
[default.basic-example] >>> Status | Info    | DEPLOYED        | The resource 
is deployed/submitted to Kubernetes, but it’s not yet considered to be stable 
and might be rolled back in the future 
   2022-09-06 13:20:02,857 o.a.f.k.o.l.ListenerUtils      [INFO ] 
[default.basic-example] >>> Event  | Info    | StatusChanged   | Job status 
changed from RECONCILING to RUNNING
   2022-09-06 13:20:02,927 o.a.f.k.o.l.ListenerUtils      [INFO ] 
[default.basic-example] >>> Status | Info    | STABLE          | The resource 
deployment is considered to be stable and won’t be rolled back 
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to