zentol commented on code in PR #20757:
URL: https://github.com/apache/flink/pull/20757#discussion_r964999081
##########
flink-core/src/main/java/org/apache/flink/api/connector/source/lib/SourceReaderFactory.java:
##########
@@ -27,9 +27,17 @@
/**
* A factory for creating source reader instances.
*
- * @param <OUT> The type of the output elements.
+ * @param <T> The type of the output elements.
*/
-public interface SourceReaderFactory<OUT, SplitT extends SourceSplit> extends
Serializable {
- /** Instantiates a new {@code SourceReader} using the provided context. */
- SourceReader<OUT, SplitT> newSourceReader(SourceReaderContext
readerContext);
+public interface SourceReaderFactory<T, SplitT extends SourceSplit> extends
Serializable {
Review Comment:
Should be moved to the same package as the `Source` interface imo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
