[
https://issues.apache.org/jira/browse/FLINK-29227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601813#comment-17601813
]
Jark Wu commented on FLINK-29227:
---------------------------------
I agree with [~chesnay]. Flink should keep the default dependencies small and
shouldn't bundle unnecessary dependencies. AFAIK, disruptor is a widely used
dependency which means the high probability of conflict, but few users use
async logger. So I think it's fine for the users who want to use async logger
to manually add disruptor to flink/lib. It's just like how Hadoop users setup
their Flink environment.
> shoud package disruptor(com.lmax) to flink lib for aync logger when
> xxconnector using it.
> -----------------------------------------------------------------------------------------
>
> Key: FLINK-29227
> URL: https://issues.apache.org/jira/browse/FLINK-29227
> Project: Flink
> Issue Type: Bug
> Components: Build System
> Affects Versions: 1.17.0
> Reporter: jackylau
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.17.0
>
> Attachments: image-2022-09-08-20-03-27-219.png
>
>
> when i develop xxConnector which dependecncy like this
> xxconnector -> log4j2 -> AsyncLoggerConfig （jar: disruptor(com.lmax)）
> xconnector loaded by user(childFirst) classloader
> log4j2 which loaded by app classloader, which also make AsyncLoggerConfig
> loaded by app classloader, according to the principle of classloader. and the
> flink lib don't have disruptor, which cause ClassNotFound. Although, the
> disruptor jar exists in my xxconnector
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
