XComp commented on code in PR #19916:
URL: https://github.com/apache/flink/pull/19916#discussion_r965971077
##########
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBaseTest.java:
##########
@@ -46,15 +47,15 @@
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.assertj.core.api.Assertions.fail;
import static org.mockito.Mockito.mock;
-import static org.powermock.api.mockito.PowerMockito.when;
+import static org.mockito.Mockito.when;
/** Tests for the {@link CassandraSinkBase}. */
-public class CassandraSinkBaseTest {
+class CassandraSinkBaseTest {
- private static final long DEFAULT_TEST_TIMEOUT = 5000;
+ private static final long DEFAULT_TEST_TIMEOUT = 5;
Review Comment:
I think it's good to limit the amount of changes to reduce the efforts
around backports. But here, with it being a quite isolated change, I would
still go for adding the unit to the variable name. It improves readability: The
value 5 (or 5000) only gets a meaning when having it connected with the time
unit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
