YuriGusev commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r966129384
########## flink-connector-aws-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbSinkElementConverter.java: ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.connectors.dynamodb.sink; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.connector.sink2.SinkWriter; +import org.apache.flink.connector.base.sink.writer.ElementConverter; +import org.apache.flink.streaming.connectors.dynamodb.util.DynamoDbAttributeValueUtils; +import org.apache.flink.util.Preconditions; + +import software.amazon.awssdk.services.dynamodb.model.WriteRequest; + +/** + * An implementation of the {@link ElementConverter} that uses the AWS DynamoDb SDK v2. The user + * needs to provide a {@link DynamoDbRequestConverter} of the {@code InputT} to transform it into a + * {@link DynamoDbWriteRequest} that may be persisted. + */ +@Internal +public class DynamoDbSinkElementConverter<InputT> Review Comment: We had a discussion earlier on that matter [here](https://github.com/apache/flink/pull/18518#discussion_r793711778) If we go for hiding the converter we do not leak underlying dynamodb sdk classes to the user, but we have to create a wrapper around their model. This means if the dynamodb client changes over time we will have to propagate model changes too. I think it may be better to allow the user to define the element converter and not do any translation ourselves (like we had it before this PR: https://github.com/YuriGusev/flink/commit/de83346dc24367ff1101ae13934dfcf1fc649de2#diff-1c18ee5b3c5b4d827778ffdf4e5d2219dbcb02fc45be0d3665357633a134995c). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
