[ 
https://issues.apache.org/jira/browse/FLINK-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15507066#comment-15507066
 ] 

ASF GitHub Bot commented on FLINK-4361:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2472#discussion_r79656257
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/Future.java ---
    @@ -0,0 +1,156 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.concurrent;
    +
    +import java.util.concurrent.CancellationException;
    +import java.util.concurrent.ExecutionException;
    +import java.util.concurrent.Executor;
    +import java.util.concurrent.TimeUnit;
    +import java.util.concurrent.TimeoutException;
    +
    +/**
    + * Flink's basic future abstraction. A future represents an asynchronous 
operation whose result
    + * will be contained in this instance upon completion.
    + *
    + * @param <T> type of the future's result
    + */
    +public interface Future<T> {
    +
    +   /**
    +    * Checks if the future has been completed. A future is completed, if 
the result has been
    +    * delivered.
    +    *
    +    * @return true if the future is completed; otherwise false
    +    */
    +   boolean isDone();
    --- End diff --
    
    I see. After all, it's a minor naming issue.


> Introduce Flink's own future abstraction
> ----------------------------------------
>
>                 Key: FLINK-4361
>                 URL: https://issues.apache.org/jira/browse/FLINK-4361
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: Stephan Ewen
>            Assignee: Till Rohrmann
>
> In order to keep the abstraction Scala Independent, we should not rely on 
> Scala Futures



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to