[ 
https://issues.apache.org/jira/browse/FLINK-29198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602257#comment-17602257
 ] 

Matthias Pohl edited comment on FLINK-29198 at 9/9/22 10:46 AM:
----------------------------------------------------------------

Thanks for picking it up and clarifying the actual problem, [~rskraba]. I 
assigned the ticket to you. Thanks to your finding, I also realized that we 
could do some cleanup around the JavaDoc and {{{}RetryRule{}}}. I created 
FLINK-29245 to cover that.


was (Author: mapohl):
Thanks for picking it up, [~rskraba] . I assigned the ticket to you. Thanks to 
your finding, I also realized that we could do some cleanup around the JavaDoc 
and {{{}RetryRule{}}}. I created FLINK-29245 to cover that.

> RetryExtension doesn't make the test fail if the retries are exhausted
> ----------------------------------------------------------------------
>
>                 Key: FLINK-29198
>                 URL: https://issues.apache.org/jira/browse/FLINK-29198
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.15.0, 1.16.0, 1.17.0
>            Reporter: Matthias Pohl
>            Assignee: Ryan Skraba
>            Priority: Major
>              Labels: starter
>
> FLINK-24627 introduced retry functionality for JUnit5-based tests. It appears 
> that the retry mechanism doesn't have the desired behavior: If the retries 
> are exhausted without the test ever succeeding will result in the test being 
> ignored. I would expect the test to fail in that case. Otherwise, a CI run 
> would succeed without anyone noticing the malfunctioning of the test.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to