snuyanzin commented on code in PR #20787:
URL: https://github.com/apache/flink/pull/20787#discussion_r966923643
##########
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/runner/JobDispatcherLeaderProcessFactoryFactory.java:
##########
@@ -131,8 +131,12 @@ private static Optional<JobGraph>
getJobGraphBasedOnDirtyJobResults(
JobGraph jobGraph, Collection<JobResult> dirtyJobResults) {
final Set<JobID> jobIdsOfFinishedJobs =
dirtyJobResults.stream().map(JobResult::getJobId).collect(Collectors.toSet());
- return jobIdsOfFinishedJobs.contains(jobGraph.getJobID())
- ? Optional.empty()
- : Optional.of(jobGraph);
+ if (jobIdsOfFinishedJobs.contains(jobGraph.getJobID())) {
+ LOG.info(
Review Comment:
put inside `getJobGraphBasedOnDirtyJobResults` since there is also
`JobDispatcherLeaderProcessFactoryFactory#extractDirtyJobResult` doing some
logging and probably it would make sense to have both doing it in corresponding
methods or both in `createFactory`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
