snuyanzin commented on code in PR #20644:
URL: https://github.com/apache/flink/pull/20644#discussion_r968165203
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala:
##########
@@ -2373,6 +2373,14 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
@Test
def testToTimestamp(): Unit = {
+ testAllApis(
Review Comment:
Would be also nice to have negative tests like with wrong input, with
different mask.
And would be nice to see test showing the behavior for the timestamp when
DST switch is happening
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
