XComp opened a new pull request, #20811:
URL: https://github.com/apache/flink/pull/20811
## What is the purpose of the change
`localCleanupAsync` is meant to be called from the `Dispatcher`'s main
thread. Any blocking calls should be avoided here. Instead, we could use
`closeAsync` which is implemented by `JobManagerRunner`.
## Brief change log
* Replaced `close` call by the corresponding `closeAsync` call
## Verifying this change
* Adds test for checking the non-blocking behavior
* Adapted two other tests in `DefaultJobManagerRunnerRegistry` since the
previously used `close` call resulted in an additional `FlinkException` being
added to the Stacktrace in case of failure through `AutoCloseableAsync#close`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
