SteNicholas commented on code in PR #291:
URL: https://github.com/apache/flink-table-store/pull/291#discussion_r969368306
##########
flink-table-store-core/src/test/java/org/apache/flink/table/store/table/WritePreemptMemoryTest.java:
##########
@@ -93,7 +93,10 @@ protected FileStoreTable
createFileStoreTable(Consumer<Configuration> configure)
Configuration conf = new Configuration();
conf.set(CoreOptions.PATH, tablePath.toString());
conf.set(CoreOptions.WRITE_MODE, WriteMode.CHANGE_LOG);
- conf.set(CoreOptions.WRITE_BUFFER_SIZE, new MemorySize(30 * 1024));
+ // Run with minimal memory to ensure a more intense preempt
+ // Currently a writer needs at least one page
Review Comment:
Is there any test case that verifies whether a writer needs at lease one
page or the behavior when less than a page?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
