masteryhx commented on code in PR #20820:
URL: https://github.com/apache/flink/pull/20820#discussion_r970376387


##########
flink-tests/src/test/java/org/apache/flink/test/checkpointing/ChangelogLocalRecoveryITCase.java:
##########
@@ -142,7 +142,6 @@ public void testRestartTM() throws Exception {
         // wait job for doing materialization.
         waitUntilCondition(
                 () -> !getAllStateHandleId(firstJobGraph.getJobID(), 
miniCluster).isEmpty());
-        miniCluster.triggerCheckpoint(firstJobGraph.getJobID()).get();

Review Comment:
   If we just remove this, IIUC, the case will always just test local recovery 
about the materialization part without non-materialization part ?
   Could we produce a checkpoint including two parts ? e.g. Using 
ControlledSource in ChangelogRecoveryITCaseBase. Or other ways ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to