godfreyhe commented on code in PR #20791:
URL: https://github.com/apache/flink/pull/20791#discussion_r970368440
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/agg/batch/AggCodeGenHelper.scala:
##########
@@ -93,6 +93,8 @@ object AggCodeGenHelper {
.asInstanceOf[Map[AggregateFunction[_, _], String]]
}
+ /** @deprecated Use [[RowTypeUtils#projectRowType]] instead. */
+ @deprecated
def projectRowType(rowType: RowType, mapping: Array[Int]): RowType = {
Review Comment:
remove this method since it's only be used in tests
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TableSinkITCase.scala:
##########
@@ -157,6 +173,52 @@ class TableSinkITCase(mode: StateBackendMode) extends
StreamingWithStateTestBase
assertEquals(expected.sorted, result.sorted)
}
+ @Test
+ def testCdcWithNonDeterministicFuncSinkWithDifferentPk(): Unit = {
Review Comment:
cdc -> non-insert-source ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
