zhuzhurk commented on code in PR #20834:
URL: https://github.com/apache/flink/pull/20834#discussion_r970524868
##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/SsgNetworkMemoryCalculationUtilsTest.java:
##########
@@ -70,6 +70,26 @@ public class SsgNetworkMemoryCalculationUtilsTest {
@Test
public void testGenerateEnrichedResourceProfile() throws Exception {
+ testGenerateEnrichedResourceProfile(
+ ResultPartitionType.PIPELINED,
+ new MemorySize(
+ TestShuffleMaster.computeRequiredShuffleMemoryBytes(0,
2)
+ +
TestShuffleMaster.computeRequiredShuffleMemoryBytes(1, 12)),
+ new
MemorySize(TestShuffleMaster.computeRequiredShuffleMemoryBytes(10, 0)));
+
+ testGenerateEnrichedResourceProfile(
Review Comment:
It's better to add some comments to illustrate why this value is expected.
This is because after all these changes it is not easy for someone unfamiliar
with this to reasoning the value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
