SmirAlex commented on code in PR #20734:
URL: https://github.com/apache/flink/pull/20734#discussion_r970670535
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/fullcache/LookupFullCache.java:
##########
@@ -72,6 +72,13 @@ public synchronized void open(Configuration parameters)
throws Exception {
} else {
reloadFailCause.addSuppressed(th);
}
+ try {
Review Comment:
I used #close to be sure that reload won't happen again after exception. It
was possible in case when there are no input records in interval between
previous and next reloads. But actually it's not necessary to call #close, I
changed the logic, so now flag `isStopped` in `CacheLoader` is being set after
encountering an exception .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
