SteNicholas commented on code in PR #262:
URL: https://github.com/apache/flink-table-store/pull/262#discussion_r970707701
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/data/AppendOnlyWriter.java:
##########
@@ -160,37 +158,19 @@ public List<DataFileMeta> close() throws Exception {
return result;
}
- private static long getMaxSequenceNumber(List<DataFileMeta> fileMetas) {
- return fileMetas.stream()
- .map(DataFileMeta::maxSequenceNumber)
- .max(Long::compare)
- .orElse(-1L);
- }
-
private void submitCompaction() throws ExecutionException,
InterruptedException {
- finishCompaction(false);
- if (compactManager.isCompactionFinished() && !toCompact.isEmpty()) {
- compactManager.submitCompaction();
- }
+ getCompactionResult(false);
+ compactManager.triggerCompaction();
}
- private void finishCompaction(boolean blocking)
+ private void getCompactionResult(boolean blocking)
Review Comment:
What about naming `trySyncLatestCompaction`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
