zentol commented on PR #20836: URL: https://github.com/apache/flink/pull/20836#issuecomment-1247258952
We don't really have tests for NoticeChecker, however one can infer the correctness from the logging output on CI: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=41020&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb If the parsing of modules from the build output is broken then this line shows it: `...Extracted 157 modules that were deployed of which 48 bundle dependencies with a total of 779 dependencies` For finding the NOTICE files we got: `... Found 44 NOTICE files to check` If the parsing of dependencies from the build output is broken, then we get warnings for all modules. If the parsing of dependencies from NOTICE is broken, then we get errors for all modules. Finally, if the comparison of the dependencies between NOTICE/build-output is broken then either everything fails or no warnings are logged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
