MartijnVisser commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/37#discussion_r972085632
##########
.github/workflows/ci.yml:
##########
@@ -53,9 +56,20 @@ jobs:
- name: Compile and test flink-connector-elasticsearch
timeout-minutes: 20
run: |
- mvn clean install -U -B --no-transfer-progress \
+ set -o pipefail
+
+ mvn clean deploy ${MVN_COMMON_OPTIONS} \
+ -DaltDeploymentRepository=validation_repository::default::file:${{
env.MVN_VALIDATION_DIR }} \
-Dscala-2.12 \
-Prun-end-to-end-tests -DdistDir=$(pwd)/../flink-1.16-SNAPSHOT \
-Dflink.convergence.phase=install -Pcheck-convergence \
${{ env.MVN_CONNECTION_OPTIONS }} \
+ -Dlog4j.configurationFile=file://$(pwd)/tools/ci/log4j.properties \
+ | tee ${{ env.MVN_BUILD_OUTPUT_FILE }}
+
+ - name: Check licensing
Review Comment:
Thought if we should consider moving the license checker earlier but I think
there's little value in that, given the amount of time it takes for a testrun
to complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
