XComp commented on code in PR #6189:
URL: https://github.com/apache/flink/pull/6189#discussion_r973057945
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java:
##########
@@ -106,7 +106,7 @@ protected void channelRead0(final ChannelHandlerContext
ctx, final HttpObject ms
final HttpContent httpContent = (HttpContent)
msg;
currentHttpPostRequestDecoder.offer(httpContent);
- while (currentHttpPostRequestDecoder.hasNext())
{
+ while (httpContent !=
LastHttpContent.EMPTY_LAST_CONTENT && currentHttpPostRequestDecoder.hasNext()) {
Review Comment:
@zentol probably I do not fully grasp this part of the code here but why do
we compare references here? Isn't that about receiving data that was encoded on
a different machine? :thinking: I'm asking because FLINK-29326 popped up. I
would expected something like `instanceof LastHttpContent` here :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
