syhily commented on code in PR #20584:
URL: https://github.com/apache/flink/pull/20584#discussion_r973592778
##########
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceBuilder.java:
##########
@@ -422,15 +421,12 @@ public PulsarSource<OUT> build() {
checkNotNull(subscriber, "No topic names or topic pattern are
provided.");
SubscriptionType subscriptionType =
configBuilder.get(PULSAR_SUBSCRIPTION_TYPE);
- if (subscriptionType == SubscriptionType.Key_Shared) {
- if (rangeGenerator == null) {
+ if (rangeGenerator == null) {
+ if (subscriptionType == SubscriptionType.Key_Shared) {
LOG.warn(
"No range generator provided for key_shared
subscription,"
+ " we would use the UniformRangeGenerator as
the default range generator.");
Review Comment:
Yep. You are right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
