zjureel commented on code in PR #19380:
URL: https://github.com/apache/flink/pull/19380#discussion_r974072694
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManager.java:
##########
@@ -104,12 +192,40 @@ public void shutdown() {
registeredPartitions.clear();
+ requestPartitionNotifiers.clear();
Review Comment:
I think we don't need to send any message to downstream for two reason:
1. When `ResultPartitionManager.shutdown` is called, it means the TM will
exit and the job will fail, the job will enter the failover process and restart
the downstream tasks
2. In the original processing, the downstream may not receive
`PartitionNotFoundException` from upstream when `ResultPartitionManager` is
shutdown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
