[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #292: [FLINK-29278] BINARY type is not supported in table store

[GitBox]

JingsongLi commented on code in PR #292:
URL: https://github.com/apache/flink-table-store/pull/292#discussion_r974118665


##########
flink-table-store-common/src/test/java/org/apache/flink/table/store/format/FileStatsExtractorTestBase.java:
##########
@@ -128,6 +129,9 @@ private Object createField(LogicalType type) {
                         randomString(random.nextInt(varCharType.getLength()) + 
1));
             case BOOLEAN:
                 return random.nextBoolean();
+            case BINARY:

Review Comment:
   We can add test for new types.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org