JingsongLi commented on code in PR #296:
URL: https://github.com/apache/flink-table-store/pull/296#discussion_r974950547
##########
flink-table-store-format/src/main/java/org/apache/flink/table/store/format/orc/OrcFileFormat.java:
##########
@@ -97,8 +98,8 @@ public BulkWriter.Factory<RowData>
createWriterFactory(RowType type) {
return new OrcBulkWriterFactory<>(
Review Comment:
There is conf in `OrcBulkWriterFactory` too.
Maybe we can create a new `OrcBulkWriterFactory` in table store to avoid new
configuration.
##########
flink-table-store-format/src/main/java/org/apache/flink/table/store/format/orc/OrcFileFormat.java:
##########
@@ -50,16 +50,21 @@
/** Orc {@link FileFormat}. The main code is copied from Flink {@code
OrcFileFormatFactory}. */
public class OrcFileFormat extends FileFormat {
- private final Configuration formatOptions;
+ private final Properties properties;
+ private final org.apache.hadoop.conf.Configuration readerConf;
+ private final org.apache.hadoop.conf.Configuration writerConf;
public OrcFileFormat(Configuration formatOptions) {
super(org.apache.flink.orc.OrcFileFormatFactory.IDENTIFIER);
- this.formatOptions = formatOptions;
+ this.properties = getOrcProperties(formatOptions);
+ this.readerConf = new org.apache.hadoop.conf.Configuration();
+ this.properties.forEach((k, v) -> readerConf.set(k.toString(),
v.toString()));
+ this.writerConf = new org.apache.hadoop.conf.Configuration();
}
@VisibleForTesting
- Configuration formatOptions() {
- return formatOptions;
+ Properties formatOptions() {
Review Comment:
formatOptions -> orcProperties?
##########
flink-table-store-format/src/main/java/org/apache/flink/table/store/format/orc/OrcFileFormat.java:
##########
@@ -50,16 +50,21 @@
/** Orc {@link FileFormat}. The main code is copied from Flink {@code
OrcFileFormatFactory}. */
public class OrcFileFormat extends FileFormat {
- private final Configuration formatOptions;
+ private final Properties properties;
Review Comment:
`orcProperties`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
