gyfora commented on code in PR #375:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/375#discussion_r976189456
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java:
##########
@@ -165,7 +165,8 @@ public void submitApplicationCluster(
if (requireHaMetadata) {
validateHaMetadataExists(conf);
}
- deployApplicationCluster(jobSpec, conf);
+
+ deployApplicationCluster(jobSpec, removeOperatorConfigs(conf));
Review Comment:
Yes I think this needs to be added to the `submitSessionCluster`
implementations for both the native and standalone service.
A proper test would actually validate all deployment modes and make sure the
config is filtered :
- Native
- Application
- Session
- Standalone
- Application
- Session
+ SessionJob
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
