pnowojski commented on code in PR #19380:
URL: https://github.com/apache/flink/pull/19380#discussion_r977515095
##########
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManagerTest.java:
##########
@@ -55,6 +68,29 @@ public void testCreateViewForRegisteredPartition() throws
Exception {
partition.getPartitionId(), 0, new
NoOpBufferAvailablityListener());
}
+ @Test
+ public void testCreateViewNotifierAfterRegisteredPartition() throws
Exception {
+ final ResultPartitionManager partitionManager = new
ResultPartitionManager();
+ final ResultPartition partition = createPartition();
+
+ partitionManager.registerResultPartition(partition);
+ PartitionRequestNotifier partitionRequestNotifier = new
TestingPartitionRequestNotifier();
+ assertNotNull(partitionManager.createSubpartitionViewOrNotify(
+ partition.getPartitionId(), 0, new
NoOpBufferAvailablityListener(), partitionRequestNotifier));
Review Comment:
> assert that partitionRequestNotifier has been notified with correct
partition and subpartition id.
has this been added? I don't see it in this test 🤔
or did I make a mistake and you added this check to
`testRegisterPartitionListenerBeforeRegisteredPartition`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
