morhidi opened a new pull request, #380:
URL: https://github.com/apache/flink-kubernetes-operator/pull/380
## What is the purpose of the change
Check CRD compatibility against all released versions.
## Brief change log
Modified the current logic to test against multiple versions:
```
<execution>
<id>deployment-crd-compatibility-check</id>
<phase>package</phase>
<goals>
<goal>run</goal>
</goals>
<configuration>
<target>
<java
classname="org.apache.flink.kubernetes.operator.validation.CrdCompatibilityChecker"
fork="true" failonerror="true">
<classpath refid="maven.compile.classpath"/>
<arg
value="file://${rootDir}/helm/flink-kubernetes-operator/crds/flinkdeployments.flink.apache.org-v1.yml"/>
<arg
value="https://raw.githubusercontent.com/apache/flink-kubernetes-operator/release-1.0.0/helm/flink-kubernetes-operator/crds/flinkdeployments.flink.apache.org-v1.yml"/>
<arg
value="https://raw.githubusercontent.com/apache/flink-kubernetes-operator/release-1.0.1/helm/flink-kubernetes-operator/crds/flinkdeployments.flink.apache.org-v1.yml"/>
<arg
value="https://raw.githubusercontent.com/apache/flink-kubernetes-operator/release-1.1.0/helm/flink-kubernetes-operator/crds/flinkdeployments.flink.apache.org-v1.yml"/>
</java>
</target>
</configuration>
</execution>
<execution>
<id>sessionjob-crd-compatibility-check</id>
<phase>package</phase>
<goals>
<goal>run</goal>
</goals>
<configuration>
<target>
<java
classname="org.apache.flink.kubernetes.operator.validation.CrdCompatibilityChecker"
fork="true" failonerror="true">
<classpath refid="maven.compile.classpath"/>
<arg
value="file://${rootDir}/helm/flink-kubernetes-operator/crds/flinksessionjobs.flink.apache.org-v1.yml"/>
<arg
value="https://raw.githubusercontent.com/apache/flink-kubernetes-operator/release-1.0.0/helm/flink-kubernetes-operator/crds/flinksessionjobs.flink.apache.org-v1.yml"/>
<arg
value="https://raw.githubusercontent.com/apache/flink-kubernetes-operator/release-1.0.1/helm/flink-kubernetes-operator/crds/flinksessionjobs.flink.apache.org-v1.yml"/>
<arg
value="https://raw.githubusercontent.com/apache/flink-kubernetes-operator/release-1.1.0/helm/flink-kubernetes-operator/crds/flinksessionjobs.flink.apache.org-v1.yml"/>
</java>
</target>
</configuration>
</execution>
```
## Verifying this change
Manually verified:
```
[INFO] --- maven-antrun-plugin:1.8:run (deployment-crd-compatibility-check)
@ flink-kubernetes-operator ---
[INFO] Executing tasks
main:
[java] 2022-09-19 18:29:37,903 o.a.f.k.o.v.CrdCompatibilityChecker
[INFO ] [.] New schema:
file:///Users/morhidi/Work/flink-kubernetes-operator/helm/flink-kubernetes-operator/crds/flinkdeployments.flink.apache.org-v1.yml
[java] 2022-09-19 18:29:37,906 o.a.f.k.o.v.CrdCompatibilityChecker
[INFO ] [.] Old schema:
https://raw.githubusercontent.com/apache/flink-kubernetes-operator/release-1.0.0/helm/flink-kubernetes-operator/crds/flinkdeployments.flink.apache.org-v1.yml
[java] 2022-09-19 18:29:40,526 o.a.f.k.o.v.CrdCompatibilityChecker
[INFO ] [.] New schema:
file:///Users/morhidi/Work/flink-kubernetes-operator/helm/flink-kubernetes-operator/crds/flinkdeployments.flink.apache.org-v1.yml
[java] 2022-09-19 18:29:40,528 o.a.f.k.o.v.CrdCompatibilityChecker
[INFO ] [.] Old schema:
https://raw.githubusercontent.com/apache/flink-kubernetes-operator/release-1.0.1/helm/flink-kubernetes-operator/crds/flinkdeployments.flink.apache.org-v1.yml
[java] 2022-09-19 18:29:41,853 o.a.f.k.o.v.CrdCompatibilityChecker
[INFO ] [.] New schema:
file:///Users/morhidi/Work/flink-kubernetes-operator/helm/flink-kubernetes-operator/crds/flinkdeployments.flink.apache.org-v1.yml
[java] 2022-09-19 18:29:41,854 o.a.f.k.o.v.CrdCompatibilityChecker
[INFO ] [.] Old schema:
https://raw.githubusercontent.com/apache/flink-kubernetes-operator/release-1.1.0/helm/flink-kubernetes-operator/crds/flinkdeployments.flink.apache.org-v1.yml
[java] Successful validation!
[INFO] Executed tasks
[INFO]
[INFO] --- maven-antrun-plugin:1.8:run (sessionjob-crd-compatibility-check)
@ flink-kubernetes-operator ---
[INFO] Executing tasks
main:
[java] 2022-09-19 18:29:44,315 o.a.f.k.o.v.CrdCompatibilityChecker
[INFO ] [.] New schema:
file:///Users/morhidi/Work/flink-kubernetes-operator/helm/flink-kubernetes-operator/crds/flinksessionjobs.flink.apache.org-v1.yml
[java] 2022-09-19 18:29:44,318 o.a.f.k.o.v.CrdCompatibilityChecker
[INFO ] [.] Old schema:
https://raw.githubusercontent.com/apache/flink-kubernetes-operator/release-1.0.0/helm/flink-kubernetes-operator/crds/flinksessionjobs.flink.apache.org-v1.yml
[java] 2022-09-19 18:29:45,462 o.a.f.k.o.v.CrdCompatibilityChecker
[INFO ] [.] New schema:
file:///Users/morhidi/Work/flink-kubernetes-operator/helm/flink-kubernetes-operator/crds/flinksessionjobs.flink.apache.org-v1.yml
[java] 2022-09-19 18:29:45,463 o.a.f.k.o.v.CrdCompatibilityChecker
[INFO ] [.] Old schema:
https://raw.githubusercontent.com/apache/flink-kubernetes-operator/release-1.0.1/helm/flink-kubernetes-operator/crds/flinksessionjobs.flink.apache.org-v1.yml
[java] 2022-09-19 18:29:45,789 o.a.f.k.o.v.CrdCompatibilityChecker
[INFO ] [.] New schema:
file:///Users/morhidi/Work/flink-kubernetes-operator/helm/flink-kubernetes-operator/crds/flinksessionjobs.flink.apache.org-v1.yml
[java] 2022-09-19 18:29:45,789 o.a.f.k.o.v.CrdCompatibilityChecker
[INFO ] [.] Old schema:
https://raw.githubusercontent.com/apache/flink-kubernetes-operator/release-1.1.0/helm/flink-kubernetes-operator/crds/flinksessionjobs.flink.apache.org-v1.yml
[java] Successful validation!
[INFO] Executed tasks
```
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
no
- Core observer or reconciler logic that is regularly executed: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
