lincoln-lil opened a new pull request, #20899:
URL: https://github.com/apache/flink/pull/20899

   ## What is the purpose of the change
   The task lifecycle was changed in FLINK-22972: a new finish() phase was 
introduced (extracted the ‘finish’ part out of the ‘close’) and the behavior  
changed in `close` method. This was some kind of 'break change' for 
TableFunction users who did some flush work in previous `close` method(< 1.14). 
This pr aims to provide a possible migration path to support it again. If 
necessary, we can also consider backporting it to the corresponding older 
versions, including 1.14~1.16.
   However, as a method that is not recommended for most users, I tend not to 
add it to the user documentation (just as  we didn't actively prompt users to 
do flush data in the close method before), so it is only been described in the 
method comments of the TableFunction, users who used this 'advanced' usage in 
previous versions 'should' be also able to get the usage of the new method.
   
   ## Brief change log
   - new finish() method in TableFunction
   - add finish() method invocation in related code generated operator
   
   ## Verifying this change
   CorrelateITCase#testTableFunctionWithFinishMethod
   
   ## Does this pull request potentially affect one of the following parts:
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
@Public(Evolving): (yes)
     - The serializers: (no )
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
     - Does this pull request introduce a new feature? (no)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to