[
https://issues.apache.org/jira/browse/FLINK-29402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609298#comment-17609298
]
Donatien edited comment on FLINK-29402 at 9/26/22 7:43 AM:
-----------------------------------------------------------
Indeed, with RocksDB API it is easy to add this new option (two new options
with {{use_direct_io_for_flush_and_compaction). }}I am not quite familiar with
the process of adding a new option, e.g adding it to the doc, localization,
..., but if you give me some resources about guidelines I'll be happy to create
a PR.
I will edit my ticket later to add some examples with Grafana of the impact of
DirectIO on performance.
Edit: text formatting
was (Author: JIRAUSER290113):
Indeed, with RocksDB API it is easy to add this new option (two new options
with {{use_direct_io_for_flush_and_compaction). I am not quite familiar with
the process of adding a new option, e.g adding it to the doc, localization,
..., but if you give me some resources about guidelines I'll be happy to create
a PR.}}
I will edit my ticket later to add some examples with Grafana of the impact of
DirectIO on performance.
> Add USE_DIRECT_READ configuration parameter for RocksDB
> -------------------------------------------------------
>
> Key: FLINK-29402
> URL: https://issues.apache.org/jira/browse/FLINK-29402
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / State Backends
> Affects Versions: 1.15.2
> Reporter: Donatien
> Priority: Not a Priority
> Labels: Enhancement, rocksdb
> Fix For: 1.15.2
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> RocksDB allows the use of DirectIO for read operations to bypass the Linux
> Page Cache. To understand the impact of Linux Page Cache on performance, one
> can run a heavy workload on a single-tasked Task Manager with a container
> memory limit identical to the TM process memory. Running this same workload
> on a TM with no container memory limit will result in better performances but
> with the host memory exceeding the TM requirement.
> Linux Page Cache are of course useful but can give false results when
> benchmarking the Managed Memory used by RocksDB. DirectIO is typically
> enabled for benchmarks on working set estimation [Zwaenepoel et
> al.|[https://arxiv.org/abs/1702.04323].]
> I propose to add a configuration key allowing users to enable the use of
> DirectIO for reads thanks to the RocksDB API. This configuration would be
> disabled by default.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)