gaborgsomogyi opened a new pull request, #386:
URL: https://github.com/apache/flink-kubernetes-operator/pull/386
## What is the purpose of the change
If the user incorrectly sets a Flink version lower than 1.15 when using 1.15
or above:
```
image: flink:1.15
flinkVersion: v1_14
```
then a spec change ends-up in exception and restart loop. In this PR we set
`SHUTDOWN_ON_APPLICATION_FINISH` to `false` when Flink version is less than
1.15.
## Brief change log
* Set `SHUTDOWN_ON_APPLICATION_FINISH` to false only on 1.15 and above
* Added unit test for all available Flink versions
## Verifying this change
* New unit test
* Manually
* Deploy app where
`image: flink:1.15 flinkVersion: v1_14`
* Wait for RUNNING state
* Change Flink config
* Double check that Flink is re-deployed and in RUNNING state again
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
no
- Core observer or reconciler logic that is regularly executed: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
