tisonkun commented on code in PR #20911:
URL: https://github.com/apache/flink/pull/20911#discussion_r981889604
##########
pom.xml:
##########
@@ -1018,30 +1018,6 @@ under the License.
</build>
</profile>
- <profile>
- <id>java17</id>
- <activation>
- <jdk>[17,)</jdk>
- </activation>
-
- <build>
- <pluginManagement>
- <plugins>
- <plugin>
-
<groupId>com.diffplug.spotless</groupId>
-
<artifactId>spotless-maven-plugin</artifactId>
- <configuration>
- <!-- Current
google format does not run on Java 17.
- Don't
upgrade it in this profile because it formats code differently.
Review Comment:
@zentol I read this line after submitting the patch. Does it mean that
google format works differently for Java 8 and Java 17? Or just it cannot work
on Java 17 so the result is "different".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
