reswqa opened a new pull request, #20912:
URL: https://github.com/apache/flink/pull/20912

   ## What is the purpose of the change
   
   The parallel serialization introduced in 
[FLINK-26675](https://issues.apache.org/jira/browse/FLINK-26675) does not 
properly handle errors.
   
   StreamConfig#triggerSerializationAndReturnFuture returns a future that is 
never completed if the serialization fails, because all we do is throw an 
exception but that isn't propagated anywhere.
   
   As a result StreamingJobGraphGenerator#createJobGraph blocks indefinitely.
   
   ## Brief change log
   
     - *Propagate exception to the `serializationFuture` when a serialization 
exception is encountered.*
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follows the 
conventions defined in our code quality guide: 
https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   
   This change added two tests in `StreamingJobGraphGeneratorTest` verified the 
serialization exceptions of coordinator and streamConfig respectively.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to