Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2533#discussion_r80010321
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java
 ---
    @@ -266,18 +265,20 @@ public void 
restorePartitionedState(List<KeyGroupsStateHandle> state) throws Exc
                        for (int i = 0; i < numKvStates; ++i) {
                                String stateName = inView.readUTF();
     
    -                           ObjectInputStream ois = new 
ObjectInputStream(inView);
    +                           TypeSerializer namespaceSerializer =
    +                                           
InstantiationUtil.deserializeObject(fsDataInputStream, userCodeClassLoader);
    +                           TypeSerializer stateSerializer =
    +                                           
InstantiationUtil.deserializeObject(fsDataInputStream, userCodeClassLoader);
     
    -                           TypeSerializer namespaceSerializer = 
(TypeSerializer) ois.readObject();
    -                           TypeSerializer stateSerializer = 
(TypeSerializer) ois.readObject();
    -                           StateTable<K, ?, ?> stateTable = new 
StateTable(stateSerializer,
    +                           StateTable<K, ?, ?> stateTable = new StateTable(
    +                                           stateSerializer,
                                                namespaceSerializer,
                                                keyGroupRange);
                                stateTables.put(stateName, stateTable);
                                kvStatesById.put(i, stateName);
                        }
     
    -                   for (int keyGroupIndex = 
keyGroupRange.getStartKeyGroup(); keyGroupIndex <= 
keyGroupRange.getEndKeyGroup(); keyGroupIndex++) {
    +                   for (int keyGroupIndex = 
keyGroupRange.getStartKeyGroup();  keyGroupIndex <= 
keyGroupRange.getEndKeyGroup(); ++keyGroupIndex) {
    --- End diff --
    
    I think i wanted to break this because it exceeds the line limit but then 
decided against it because IntelliJ messed up the formatting for loops. Nothing 
wrong there at all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to