gyfora opened a new pull request, #390:
URL: https://github.com/apache/flink-kubernetes-operator/pull/390
## What is the purpose of the change
This PR removes a committed empty jar file that was used in the
`FlinkSessionJob` deployment logic when the job is already on the session class
classpath.
The previous behaviour violated the `no binaries in source release`
philosophy. We now simply generate the empty jar programatically which is
equally simply.
## Brief change log
- *remove noop.jar*
- *add logic to generate empty jar instead on the fly*
## Verifying this change
There are some existing tests + manually verified on local minikube.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
no
- Core observer or reconciler logic that is regularly executed: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
