zentol commented on code in PR #40: URL: https://github.com/apache/flink-connector-elasticsearch/pull/40#discussion_r983962292
##########
pom.xml:
##########
@@ -408,380 +370,15 @@ under the License.
<module>flink-sql-connector-elasticsearch7</module>
</modules>
</profile>
-
- <profile>
- <id>java11</id>
- <activation>
- <jdk>[11,)</jdk>
- </activation>
-
- <build>
- <pluginManagement>
- <plugins>
- <plugin>
-
<groupId>org.codehaus.mojo</groupId>
-
<artifactId>build-helper-maven-plugin</artifactId>
- <version>1.7</version>
- </plugin>
- <plugin>
-
<groupId>org.apache.maven.plugins</groupId>
-
<artifactId>maven-shade-plugin</artifactId>
- <version>3.2.4</version>
- </plugin>
- <plugin>
-
<groupId>io.github.zentol.japicmp</groupId>
-
<artifactId>japicmp-maven-plugin</artifactId>
- <dependencies>
- <dependency>
-
<groupId>javax.xml.bind</groupId>
-
<artifactId>jaxb-api</artifactId>
-
<version>2.3.0</version>
- </dependency>
- <dependency>
-
<groupId>com.sun.xml.bind</groupId>
-
<artifactId>jaxb-impl</artifactId>
-
<version>2.3.1</version>
- </dependency>
- <dependency>
-
<groupId>com.sun.xml.bind</groupId>
-
<artifactId>jaxb-core</artifactId>
-
<version>2.3.0</version>
- </dependency>
- <dependency>
-
<groupId>javax.activation</groupId>
-
<artifactId>activation</artifactId>
-
<version>1.1.1</version>
- </dependency>
- </dependencies>
- </plugin>
- <plugin>
-
<groupId>org.apache.maven.plugins</groupId>
-
<artifactId>maven-javadoc-plugin</artifactId>
- <configuration>
-
<additionalJOptions>
-
<additionalJOption>--add-exports=java.base/sun.net.util=ALL-UNNAMED</additionalJOption>
-
</additionalJOptions>
- </configuration>
- </plugin>
- </plugins>
- </pluginManagement>
- </build>
- </profile>
-
- <profile>
- <id>java17</id>
- <activation>
- <jdk>[17,)</jdk>
- </activation>
-
- <build>
- <pluginManagement>
- <plugins>
- <plugin>
-
<groupId>com.diffplug.spotless</groupId>
-
<artifactId>spotless-maven-plugin</artifactId>
- <configuration>
- <!-- Current
google format does not run on Java 17.
- Don't
upgrade it in this profile because it formats code differently.
-
Re-evaluate once support for Java 8 is dropped. -->
-
<skip>true</skip>
- </configuration>
- </plugin>
- </plugins>
- </pluginManagement>
- </build>
- </profile>
-
- <profile>
- <id>java11-target</id>
- <build>
- <plugins>
- <plugin>
-
<groupId>org.apache.maven.plugins</groupId>
-
<artifactId>maven-compiler-plugin</artifactId>
- <configuration>
- <source>11</source>
- <target>11</target>
- <compilerArgs
combine.children="append">
-
<arg>--add-exports=java.base/sun.net.util=ALL-UNNAMED</arg>
-
<arg>--add-exports=java.management/sun.management=ALL-UNNAMED</arg>
-
<arg>--add-exports=java.rmi/sun.rmi.registry=ALL-UNNAMED</arg>
-
<arg>--add-exports=java.security.jgss/sun.security.krb5=ALL-UNNAMED</arg>
- </compilerArgs>
- </configuration>
- </plugin>
- </plugins>
- </build>
- </profile>
-
- <profile>
- <id>java17-target</id>
- <build>
- <plugins>
- <plugin>
-
<groupId>org.apache.maven.plugins</groupId>
-
<artifactId>maven-compiler-plugin</artifactId>
- <configuration>
- <source>17</source>
- <target>17</target>
- <compilerArgs
combine.children="append">
-
<arg>--add-exports=java.base/sun.net.util=ALL-UNNAMED</arg>
-
<arg>--add-exports=java.management/sun.management=ALL-UNNAMED</arg>
-
<arg>--add-exports=java.rmi/sun.rmi.registry=ALL-UNNAMED</arg>
-
<arg>--add-exports=java.security.jgss/sun.security.krb5=ALL-UNNAMED</arg>
- </compilerArgs>
- </configuration>
- </plugin>
- </plugins>
- </build>
- </profile>
-
- <profile>
- <id>fast</id>
- <activation>
- <property>
- <name>fast</name>
- </property>
- </activation>
- <build>
- <pluginManagement>
- <plugins>
- <plugin>
-
<groupId>org.apache.rat</groupId>
-
<artifactId>apache-rat-plugin</artifactId>
- <configuration>
-
<skip>true</skip>
- </configuration>
- </plugin>
- <plugin>
-
<groupId>org.apache.maven.plugins</groupId>
-
<artifactId>maven-checkstyle-plugin</artifactId>
- <configuration>
-
<skip>true</skip>
- </configuration>
- </plugin>
- <plugin>
-
<groupId>com.diffplug.spotless</groupId>
-
<artifactId>spotless-maven-plugin</artifactId>
- <configuration>
-
<skip>true</skip>
- </configuration>
- </plugin>
- <plugin>
-
<groupId>org.scalastyle</groupId>
-
<artifactId>scalastyle-maven-plugin</artifactId>
- <configuration>
-
<skip>true</skip>
- </configuration>
- </plugin>
- <plugin>
-
<groupId>org.apache.maven.plugins</groupId>
-
<artifactId>maven-enforcer-plugin</artifactId>
- <configuration>
-
<skip>true</skip>
- </configuration>
- </plugin>
- <plugin>
-
<groupId>org.apache.maven.plugins</groupId>
-
<artifactId>maven-javadoc-plugin</artifactId>
- <configuration>
-
<skip>true</skip>
- </configuration>
- </plugin>
- <plugin>
-
<groupId>io.github.zentol.japicmp</groupId>
-
<artifactId>japicmp-maven-plugin</artifactId>
- <configuration>
-
<skip>true</skip>
- </configuration>
- </plugin>
- </plugins>
- </pluginManagement>
- </build>
- </profile>
-
- <profile>
- <id>check-convergence</id>
- <activation>
- <property>
- <name>check-convergence</name>
- </property>
- </activation>
- <build>
- <plugins>
- <plugin>
-
<groupId>org.apache.maven.plugins</groupId>
-
<artifactId>maven-enforcer-plugin</artifactId>
- <executions>
- <execution>
-
<id>dependency-convergence</id>
-
<phase>${flink.convergence.phase}</phase>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
- </profile>
-
- <profile>
- <!-- used for SNAPSHOT and regular releases -->
- <id>docs-and-source</id>
- <activation>
- <property>
- <name>docs-and-source</name>
- </property>
- </activation>
- <build>
- <plugins>
- <plugin>
-
<groupId>org.apache.maven.plugins</groupId>
-
<artifactId>maven-source-plugin</artifactId>
-
<version>2.2.1</version><!--$NO-MVN-MAN-VER$-->
- <executions>
- <execution>
-
<id>attach-sources</id>
- <goals>
-
<goal>jar</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- <plugin>
-
<groupId>org.apache.maven.plugins</groupId>
-
<artifactId>maven-javadoc-plugin</artifactId>
- <configuration>
- <quiet>true</quiet>
- </configuration>
- <executions>
- <execution>
-
<id>attach-javadocs</id>
- <goals>
-
<goal>jar</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
- </profile>
-
- <profile>
- <id>release</id>
- <activation>
- <property>
- <name>release</name>
- </property>
- </activation>
- <properties>
- <target.java.version>1.8</target.java.version>
- </properties>
- <build>
- <plugins>
- <plugin>
-
<groupId>org.apache.maven.plugins</groupId>
-
<artifactId>maven-gpg-plugin</artifactId>
- <version>1.4</version>
- <executions>
- <execution>
-
<id>sign-artifacts</id>
-
<phase>verify</phase>
- <goals>
-
<goal>sign</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- <plugin>
-
<groupId>org.apache.maven.plugins</groupId>
-
<artifactId>maven-enforcer-plugin</artifactId>
- <executions>
- <execution>
-
<id>enforce-maven</id>
- <goals>
-
<goal>enforce</goal>
- </goals>
- <configuration>
- <rules>
-
<requireMavenVersion>
-
<!-- maven version must be lower than 3.3. See FLINK-3158 -->
-
<version>(,3.3)</version>
-
</requireMavenVersion>
-
<requireJavaVersion>
-
<version>1.8.0</version>
-
</requireJavaVersion>
- </rules>
- </configuration>
- </execution>
- </executions>
- </plugin>
- <plugin>
-
<groupId>org.apache.maven.plugins</groupId>
-
<artifactId>maven-javadoc-plugin</artifactId>
- <executions>
- <execution>
-
<id>attach-javadocs</id>
- <goals>
-
<goal>jar</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- </plugins>
- <pluginManagement>
- <plugins>
- <plugin>
-
<groupId>org.apache.maven.plugins</groupId>
-
<artifactId>maven-release-plugin</artifactId>
- <version>2.1</version>
- <configuration>
-
<mavenExecutorId>forked-path</mavenExecutorId>
-
<useReleaseProfile>false</useReleaseProfile>
-
<arguments>${arguments} -Psonatype-oss-release</arguments>
- </configuration>
- </plugin>
- </plugins>
- </pluginManagement>
- </build>
- </profile>
</profiles>
<build>
<plugins>
- <!--
- We need to include this here because some of our
modules have transitive dependencies
- on jdbm1, which is of type "bundle". This only works if
you include the
- maven-bundle-plugin (see
https://issues.apache.org/jira/browse/DIRSHARED-134). We need
- the plugin in the root pom because Javadoc aggregation
runs only in the root pom and
- not the specific poms. Not having this here was the
cause for FLINK-7702.
- -->
- <plugin>
- <groupId>org.apache.felix</groupId>
- <artifactId>maven-bundle-plugin</artifactId>
- <version>3.0.1</version>
- <inherited>true</inherited>
- <extensions>true</extensions>
- </plugin>
Review Comment:
This was not ported to the parent because it _may_ be unnecessary; let's
find out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
