ferenc-csaky commented on code in PR #20542:
URL: https://github.com/apache/flink/pull/20542#discussion_r984470999


##########
flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/sink/HBaseSinkFunction.java:
##########
@@ -191,8 +195,10 @@ private void checkErrorAndRethrow() {
     public void invoke(T value, Context context) throws Exception {
         checkErrorAndRethrow();
 
-        mutator.mutate(mutationConverter.convertToMutation(value));
-
+        Mutation mutation = mutationConverter.convertToMutation(value);
+        synchronized (mutationMap) {
+            mutationMap.put(mutation.getRow(), mutation);

Review Comment:
   To overcome this, I suggest to convert it to a base64 string, e.g.:
   ```java
   String key = Base64.getEncoder().encodeToString(mutation.getRow());
   ```
   
   Or to create a simple wrapper class, where the `equals` and `hashCode` are 
overridden properly for arrays.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to