[
https://issues.apache.org/jira/browse/FLINK-29485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17612505#comment-17612505
]
Matthias Pohl commented on FLINK-29485:
---------------------------------------
I misinterpreted the {{TypeSerializerUpgradeTestBase#CURRENT_VERSION}} member.
I updated the Jira issues description: We might want to add some comments in
the relevant migration tests to add a bit of context to avoid confusion in the
future.
> TypeSerializerUpgradeTestBase still uses 1.15 as the current version on
> master and release-1.16
> -----------------------------------------------------------------------------------------------
>
> Key: FLINK-29485
> URL: https://issues.apache.org/jira/browse/FLINK-29485
> Project: Flink
> Issue Type: Bug
> Components: Documentation, Tests
> Affects Versions: 1.16.0, 1.17.0, 1.15.2
> Reporter: Matthias Pohl
> Priority: Minor
> Labels: starter
>
> -TypeSerializerUpgradeTestBase still refers to 1.15 as the current version.
> We could use FlinkVersions.current() instead to avoid running into this issue
> again for future major updates.-
> -I didn't check other occurrences of FlinkVersions. It should be verified as
> part of this Jira issue that we don't have the same issue in other locations
> as well.-
> {{TypeSerializerUpgradeTestBase.CURRENT_VERSION}} can be a bit misleading. We
> might want to add some comment explaining that it's referring to the
> currently actually released major version and that the corresponding test
> data should reflect the state of {{1.x.0}} as a baseline for any tests
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
