zentol commented on code in PR #20976: URL: https://github.com/apache/flink/pull/20976#discussion_r988908421
########## flink-libraries/flink-state-processing-api/src/test/java/org/apache/flink/state/api/SavepointWriterUidModificationITCase.java: ########## @@ -0,0 +1,276 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.state.api; + +import org.apache.flink.api.common.RuntimeExecutionMode; +import org.apache.flink.api.common.functions.RichMapFunction; +import org.apache.flink.api.common.state.ValueState; +import org.apache.flink.api.common.state.ValueStateDescriptor; +import org.apache.flink.api.common.typeinfo.Types; +import org.apache.flink.api.java.tuple.Tuple2; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.runtime.jobgraph.SavepointRestoreSettings; +import org.apache.flink.runtime.state.FunctionInitializationContext; +import org.apache.flink.runtime.state.FunctionSnapshotContext; +import org.apache.flink.runtime.testutils.MiniClusterResourceConfiguration; +import org.apache.flink.state.api.functions.KeyedStateBootstrapFunction; +import org.apache.flink.state.api.functions.StateBootstrapFunction; +import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment; +import org.apache.flink.streaming.api.graph.StreamGraph; +import org.apache.flink.test.junit5.MiniClusterExtension; +import org.apache.flink.util.AbstractID; +import org.apache.flink.util.CloseableIterator; + +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.extension.RegisterExtension; +import org.junit.jupiter.api.io.TempDir; + +import java.nio.file.Path; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collection; +import java.util.List; +import java.util.function.BiConsumer; +import java.util.function.Consumer; + +import static org.assertj.core.api.Assertions.assertThat; + +/** IT test for modifying UIDs in savepoints. */ +public class SavepointWriterUidModificationITCase { + + @RegisterExtension + static final MiniClusterExtension MINI_CLUSTER_RESOURCE = + new MiniClusterExtension( + new MiniClusterResourceConfiguration.Builder() + .setNumberTaskManagers(1) + .setNumberSlotsPerTaskManager(4) + .build()); + + private static final Collection<Integer> STATE_1 = Arrays.asList(1, 2, 3); + private static final Collection<Integer> STATE_2 = Arrays.asList(4, 5, 6); + + private static final ValueStateDescriptor<Integer> STATE_DESCRIPTOR = + new ValueStateDescriptor<>("number", Types.INT); + + @Test + public void testAddUid(@TempDir Path tmp) throws Exception { + final String uidHash = new AbstractID().toHexString(); + final String uid = "uid"; + final String originalSavepoint = + bootstrapState( + tmp, + (env, writer) -> + writer.withOperator( + OperatorIdentifier.forUidHash(uidHash), + bootstrap(env, STATE_1))); + final String newSavepoint = + modifySavepoint( + tmp, + originalSavepoint, + writer -> + writer.changeOperatorIdentifier( + OperatorIdentifier.forUidHash(uidHash), + OperatorIdentifier.forUid(uid))); + + runAndValidate(newSavepoint, Tuple2.of(STATE_1, uid)); + } + + @Test + public void testChangeUid(@TempDir Path tmp) throws Exception { + final String uid = "uid"; + final String newUid = "fabulous"; + final String originalSavepoint = + bootstrapState( + tmp, + (env, writer) -> + writer.withOperator( + OperatorIdentifier.forUid(uid), bootstrap(env, STATE_1))); + final String newSavepoint = + modifySavepoint( + tmp, + originalSavepoint, + writer -> + writer.changeOperatorIdentifier( + OperatorIdentifier.forUid(uid), + OperatorIdentifier.forUid(newUid))); + + runAndValidate(newSavepoint, Tuple2.of(STATE_1, newUid)); + } + + @Test + public void testSwapUid(@TempDir Path tmp) throws Exception { + final String uid1 = "uid1"; + final String uid2 = "uid2"; + final String originalSavepoint = + bootstrapState( + tmp, + (env, writer) -> + writer.withOperator( + OperatorIdentifier.forUid(uid1), + bootstrap(env, STATE_1)) + .withOperator( + OperatorIdentifier.forUid(uid2), + bootstrap(env, STATE_2))); + final String newSavepoint = + modifySavepoint( + tmp, + originalSavepoint, + writer -> + writer.changeOperatorIdentifier( + OperatorIdentifier.forUid(uid1), + OperatorIdentifier.forUid(uid2)) + .changeOperatorIdentifier( + OperatorIdentifier.forUid(uid2), + OperatorIdentifier.forUid(uid1))); + + runAndValidate(newSavepoint, Tuple2.of(STATE_1, uid2), Tuple2.of(STATE_2, uid1)); + } + + private static String bootstrapState( + Path tmp, BiConsumer<StreamExecutionEnvironment, SavepointWriter> mutator) + throws Exception { + final String savepointPath = + tmp.resolve(new AbstractID().toHexString()).toAbsolutePath().toString(); + + final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment(); + env.setRuntimeMode(RuntimeExecutionMode.AUTOMATIC); + + final SavepointWriter writer = SavepointWriter.newSavepoint(128); + + mutator.accept(env, writer); + + writer.write(savepointPath); + + env.execute("Bootstrap"); + + return savepointPath; + } + + private static StateBootstrapTransformation<Integer> bootstrap( + StreamExecutionEnvironment env, Collection<Integer> data) { + return OperatorTransformation.bootstrapWith(env.fromCollection(data)) + .keyBy(v -> v) + .transform(new StateBootstrapper()); + } + + private static String modifySavepoint( + Path tmp, String savepointPath, Consumer<SavepointWriter> mutator) throws Exception { + final String newSavepointPath = + tmp.resolve(new AbstractID().toHexString()).toAbsolutePath().toString(); + + final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment(); + env.setRuntimeMode(RuntimeExecutionMode.AUTOMATIC); + + SavepointWriter writer = SavepointWriter.fromExistingSavepoint(savepointPath); + + // SavepointWriter enforces at least one operation; add a dummy that doesn't write anything + writer.withOperator( + OperatorIdentifier.forUid("dummy"), + OperatorTransformation.bootstrapWith(env.fromElements(1)) + .transform(new DummyBootstrapper())); Review Comment: This is quite annoying and I'd like to get rid of it in a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
