XComp commented on code in PR #18760:
URL: https://github.com/apache/flink/pull/18760#discussion_r989215635
##########
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/cursor/StopCursor.java:
##########
@@ -33,8 +33,8 @@
import java.io.Serializable;
/**
- * A interface for users to specify the stop position of a pulsar
subscription. Since it would be
- * serialized into split. The implementation for this interface should be well
considered. I don't
+ * An interface for users to specify the stop position of a pulsar
subscription. Since it would be
+ * serialized into split, the implementation for this interface should be well
considered. I don't
* recommend adding extra internal state for this implementation.
Review Comment:
```suggestion
* serialized into split, the implementation for this interface should be
well considered. It's not
* recommended to add extra internal state for this implementation.
```
##########
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java:
##########
@@ -197,7 +197,7 @@ public KafkaSourceBuilder<OUT>
setKafkaSubscriber(KafkaSubscriber kafkaSubscribe
}
/**
- * Specify from which offsets the KafkaSource should start consume from by
providing an {@link
+ * Specify from which offsets the KafkaSource should start consumig from
by providing an {@link
Review Comment:
```suggestion
* Specify from which offsets the KafkaSource should start consuming
from by providing an {@link
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
