JingsongLi commented on code in PR #298:
URL: https://github.com/apache/flink-table-store/pull/298#discussion_r990578391
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/MergeTreeWriter.java:
##########
@@ -163,7 +163,11 @@ public void flushMemory() throws Exception {
// adding one record then remove one record, but after merging
this record will not
// appear in lsm file. This is OK because we can also skip
this changelog.
DataFileMeta fileMeta = writer.result();
- if (fileMeta != null) {
+ if (fileMeta == null) {
+ for (String extraFile : extraFiles) {
Review Comment:
Can we add a test for this? Maybe in
`ChangelogWithKeyFileStoreTableTest.testStreamingChangelog`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
