weibozhao commented on code in PR #156: URL: https://github.com/apache/flink-ml/pull/156#discussion_r990719982
########## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java: ########## @@ -47,7 +47,9 @@ /** * A Transformer which combines a given list of input columns into a vector column. Types of input - * columns must be either vector or numerical value. + * columns must be either vector or numerical types. The elements assembled in the same column must + * have the same size. If the size of the element is not equal to sizes[columnIdx], it will throw an + * IllegalArgumentException. Review Comment: If the job is a streaming job, I think passing this record is more proper. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
