kristoffSC commented on code in PR #20979:
URL: https://github.com/apache/flink/pull/20979#discussion_r991118672
##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/sink/committables/CommittableCollectorSerializerTest.java:
##########
@@ -72,38 +73,86 @@ void testCommittableCollectorV1SerDe() throws IOException {
@Test
void testCommittableCollectorV2SerDe() throws IOException {
- final CommittableCollector<Integer> committableCollector = new
CommittableCollector<>(2, 3);
- committableCollector.addMessage(new CommittableSummary<>(2, 3, 1L, 1,
1, 0));
- committableCollector.addMessage(new CommittableSummary<>(2, 3, 2L, 1,
1, 0));
- committableCollector.addMessage(new CommittableWithLineage<>(1, 1L,
2));
- committableCollector.addMessage(new CommittableWithLineage<>(2, 2L,
2));
+ int subtaskId = 2;
Review Comment:
thanks,
with
[getSummary](https://github.com/apache/flink/pull/20979/files#r991004178) i
managed to not expose new information from `CheckpointCommittableManagerImpl`.
I do think that `CommittableCollectorSerializerTest` is a good place for
this check (I;m asserting additional values only)
since the original issue FLINK-29509 was caused by indirectly by
deserialization - now we check if we use corect constructor hence we have
proper values.
Additionally I will take a look at `CommitterOperatorTest`
##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/sink/committables/CommittableCollectorSerializerTest.java:
##########
@@ -72,38 +73,86 @@ void testCommittableCollectorV1SerDe() throws IOException {
@Test
void testCommittableCollectorV2SerDe() throws IOException {
- final CommittableCollector<Integer> committableCollector = new
CommittableCollector<>(2, 3);
- committableCollector.addMessage(new CommittableSummary<>(2, 3, 1L, 1,
1, 0));
- committableCollector.addMessage(new CommittableSummary<>(2, 3, 2L, 1,
1, 0));
- committableCollector.addMessage(new CommittableWithLineage<>(1, 1L,
2));
- committableCollector.addMessage(new CommittableWithLineage<>(2, 2L,
2));
+ int subtaskId = 2;
Review Comment:
thanks,
with
[getSummary](https://github.com/apache/flink/pull/20979/files#r991004178) i
managed to not expose new information from `CheckpointCommittableManagerImpl`.
I do think that `CommittableCollectorSerializerTest` is a good place for
this check (I;m asserting additional values only)
since the original issue FLINK-29509 was caused by indirectly by
deserialization - now we check if we use correct constructor hence we have
proper values.
Additionally I will take a look at `CommitterOperatorTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
