mxm commented on code in PR #20953:
URL: https://github.com/apache/flink/pull/20953#discussion_r991532503
##########
flink-core/src/main/java/org/apache/flink/configuration/ConfigOption.java:
##########
@@ -64,22 +64,37 @@
*
* <ul>
* <li>typeClass == atomic class (e.g. {@code Integer.class}) -> {@code
ConfigOption<Integer>}
- * <li>typeClass == {@code Map.class} -> {@code ConfigOption<Map<String,
String>>}
- * <li>typeClass == atomic class and isList == true for {@code
ConfigOption<List<Integer>>}
+ * <li>typeClass == atomic class and type == LIST for {@code
ConfigOption<List<Integer>>}
Review Comment:
This has been moved to https://github.com/apache/flink/pull/21008 alongside
with more tests. The list type is not sufficient for this kind of
configuration. It's not a logical limitation to support many value types but
not allow them in maps as values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
