[GitHub] [flink] luoyuxia commented on a diff in pull request #20987: [FLINK-29432][Connector/Hive] Remove use of GenericNVL and use Colaese

Mon, 10 Oct 2022 18:50:46 -0700 


luoyuxia commented on code in PR #20987:
URL: https://github.com/apache/flink/pull/20987#discussion_r991746653


##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserTypeCheckProcFactory.java:
##########
@@ -1216,7 +1216,7 @@ protected ExprNodeDesc getXpathOrFuncExprNodeDesc(
                     // Rewrite CASE into NVL
                     desc =
                             ExprNodeGenericFuncDesc.newInstance(
-                                    new GenericUDFNvl(),
+                                    new GenericUDFCoalesce(),

Review Comment:
   I'm afriad of changing it may bring other bugs as reported int 
[HIVE-24902](https://issues.apache.org/jira/browse/HIVE-24902).
   Also, I still pefer not to change it as I commented in the jira 
[FLINK-29432](https://issues.apache.org/jira/browse/FLINK-29432)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to