afedulov commented on PR #20757: URL: https://github.com/apache/flink/pull/20757#issuecomment-1274772759
> Tried it out in some internal projects and it worked like charm. :heart: Perfect, glad to hear! :clap: > Should we deprecate the existing DataGeneratorSource in flink-streaming-java? Good question. It seems to be mainly used for Row-based data generation, so some work might be needed if we also want to provide utilities for our new generator for this use case out of the box. It also claims to be "stateful" [DataGeneratorSource.java#L35](https://github.com/apache/flink/blob/master/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/datagen/DataGeneratorSource.java#L35), however, the actual generators seem to all default to no-op [DataGenerator.java#L45](https://github.com/apache/flink/blob/c6997c97c575d334679915c328792b8a3067cfb5/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/datagen/DataGenerator.java#L45), so it should be no issue to use the generator function instead. The next goal is to deprecate `SourceFunction` and the old `DataGeneratorSource` would fall into the "to transitively deprecate" bucket anyhow. We can either do it here or in the next step, I have no preference. > What about documentation? :+1: I'll work on that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
