XComp commented on code in PR #21019:
URL: https://github.com/apache/flink/pull/21019#discussion_r992414646
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java:
##########
@@ -841,6 +842,12 @@ private StreamConfig createJobVertex(Integer streamNodeId,
OperatorChainInfo cha
},
serializationExecutor));
}
+ coordinatorSerializationFutures.add(
+ FutureUtils.combineAll(serializationFutures)
+ .thenAccept(
+ serializedCoordinators ->
+ serializedCoordinators.forEach(
+
jobVertex::addOperatorCoordinator)));
Review Comment:
hm, yeah that's what I had in mind. But if we want to do it properly, we'd
have to pass the `Collection<SerialiazedValue<OperatorCoordinator>>` as a
constructor parameter rather than using the `JobVertex#addOperatorCoordinator`
(which we would remove then). Am I following here correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
