[
https://issues.apache.org/jira/browse/FLINK-29563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615878#comment-17615878
]
Etienne Chauchot commented on FLINK-29563:
------------------------------------------
Ok let's forget about automatically disabling the not-suited tests (for ex the
ones targeted to unbounded sources when the tested source is bounded). A
possible solution could be to override them and disable them in the ITCase
(that extends the test suite).
For the particular case of the metrics tests, as I wrote this test should
indeed be run in both bounded and unbounded cases. It is just that for the
bounded case, [killing the
job|https://github.com/apache/flink/blob/4934bd69052f2a69e8021d337373f4480c802359/flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/testsuites/SourceTestSuiteBase.java#L469]
is not needed and in some cases (fast job) the kill is executed when the job
is already in the finished state leading to a confusing exception. This is why
for the bounded case the killJob should be removed. What I propose is to allow
the implemeter to pass the boundedness in its ITCase to run the corresponding
version of this test.
WDYT ?
> SourceTestSuiteBase#testSourceMetrics enters an infinite waiting loop in case
> the number of records counter is wrong
> --------------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-29563
> URL: https://issues.apache.org/jira/browse/FLINK-29563
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
>
> The call to _CommonTestUtils#waitUntilCondition_ (1) makes the test wait for
> the condition _Precision.equals(allRecordSize, sumNumRecordsIn)_. In case the
> reported number of records is incorrect, the waiting loop never ends.
> [1]
> https://github.com/apache/flink/blob/a6092b1176d15a7af32a7eb19f59cdfeab172034/flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/testsuites/SourceTestSuiteBase.java#L451
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
