[
https://issues.apache.org/jira/browse/FLINK-25538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616259#comment-17616259
]
Sergey Nuyanzin edited comment on FLINK-25538 at 10/12/22 7:50 AM:
-------------------------------------------------------------------
Hi [~ashmeet] thanks for taking it.
Is there any way to see the error you're referring to e.g. on CI?
I was able to find only NullPointerException for the PR [1]
The reason (don't know if it is still actual or not) of that NPE is that
{{KafkaChangelogTableITCase}} is migrated to JUnit5 and {{KafkaTableTestBase}}
is not(still on JUnit4), while {{KafkaChangelogTableITCase extends
KafkaTableTestBase}}
+ 1 more nit comment about PR: there is no need to touch {{docs/theme/book}}
within this PR since there is no JUnit5 relations. It would decrease amount of
changed lines and simplifies/speeds up review process. In case you feel that
something should be fixed there it's better to create another PR for that.
[1]
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=41889&view=logs&j=aa18c3f6-13b8-5f58-86bb-c1cffb239496&t=502fb6c0-30a2-5e49-c5c2-a00fa3acb203&l=37282
was (Author: sergey nuyanzin):
Hi [~ashmeet] thanks for taking it.
Is there any way to see the error you're referring to e.g. on CI?
I was able to find only NullPointerException for the PR [1]
The reason (don't know if it is still actual or not) of that NPE is that
{{KafkaChangelogTableITCase}} is migrated to JUnit4 and {{KafkaTableTestBase}}
is not while {{KafkaChangelogTableITCase extends KafkaTableTestBase}}
+ 1 more nit comment about PR: there is no need to touch {{docs/theme/book}}
within this PR since there is no JUnit5 relations. It would decrease amount of
changed lines and simplifies/speeds up review process. In case you feel that
something should be fixed there it's better to create another PR for that.
[1]
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=41889&view=logs&j=aa18c3f6-13b8-5f58-86bb-c1cffb239496&t=502fb6c0-30a2-5e49-c5c2-a00fa3acb203&l=37282
> [JUnit5 Migration] Module: flink-connector-kafka
> ------------------------------------------------
>
> Key: FLINK-25538
> URL: https://issues.apache.org/jira/browse/FLINK-25538
> Project: Flink
> Issue Type: Sub-task
> Components: Connectors / Kafka
> Reporter: Qingsheng Ren
> Assignee: Ashmeet Kandhari
> Priority: Minor
> Labels: pull-request-available, starter
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
